----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/#review56612 -----------------------------------------------------------
cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39475> endif() cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39476> endif() cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39480> if(QxOrm_DEBUG_LIBRARIES or QxOrm_RELEASE_LIBRARIES) is enough and you can remove the two if/endif blocks above cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39481> This should be set by FindPackageHandleStandardArgs cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39477> endif() cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39478> This part assumes that both release & debug libraries were found I suggest: if(QxOrm_RELEASE_LIBRARIES) set(QxOrm_LIBRARIES ${QxOrm_RELEASE_LIBRARIES}) elseif(QxOrm_DEBUG_LIBRARIES) set(QxOrm_LIBRARIES ${QxOrm_DEBUG_LIBRARIES}) endif() cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39479> endif() - Christophe Giboudeaux On April 26, 2014, 11:57 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117783/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 11:57 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Adding -D_QX_RELEASE_MODE when we are linking against QxOrm release mode > links fine. As suggested by QxOrm devs > > > Diffs > ----- > > cmake/FindQxOrm.cmake 37c0799 > libs/mediacenter/CMakeLists.txt 51f657a > > Diff: https://git.reviewboard.kde.org/r/117783/diff/ > > > Testing > ------- > > 1) We are building in Release mode > - QxOrm is in release mode > - QxOrm is in debug mode > - Both release and debug version of QxOrm is available > > 2) We are building in Debug mode > - QxOrm is in release mode > - QxOrm is in debug mode > - Both release and debug version of QxOrm is available > > All pass > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel