----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/#review56617 -----------------------------------------------------------
cmake/FindQxOrm.cmake <https://git.reviewboard.kde.org/r/117783/#comment39483> copy paste is bad :) libs/mediacenter/CMakeLists.txt <https://git.reviewboard.kde.org/r/117783/#comment39484> That's now one or another - Christophe Giboudeaux On April 26, 2014, 1:11 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117783/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 1:11 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Adding -D_QX_RELEASE_MODE when we are linking against QxOrm release mode > links fine. As suggested by QxOrm devs > > > Diffs > ----- > > cmake/FindQxOrm.cmake 37c0799 > libs/mediacenter/CMakeLists.txt 51f657a > > Diff: https://git.reviewboard.kde.org/r/117783/diff/ > > > Testing > ------- > > 1) We are building in Release mode > - QxOrm is in release mode > - QxOrm is in debug mode > - Both release and debug version of QxOrm is available > > 2) We are building in Debug mode > - QxOrm is in release mode > - QxOrm is in debug mode > - Both release and debug version of QxOrm is available > > All pass > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
