> On May 13, 2014, 2:47 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/CMakeLists.txt, line 39 > > <https://git.reviewboard.kde.org/r/116024/diff/4/?file=272717#file272717line39> > > > > why do you link against Qt5::OpenGL and find it? OpenGL is part of Gui > > David Edmundson wrote: > For anyone else who gets this problem: > QGlContext needs porting to QOpenGLContext which is in Gui. > > Then you don't need to link OpenGL directly
the check, and link for Qt5OpenGL is indeed needed, otherwise: /home/abuild/rpmbuild/BUILD/plasma-framework-4.99.0git~20140515~09453cf/src/declarativeimports/core/fadingnode.cpp:23:31: fatal error: QtOpenGL/QGLContext: No such file or directory - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review57872 ----------------------------------------------------------- On May 15, 2014, 4:19 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116024/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 4:19 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Port IconItem to native QSGTexture including the animation. > This will save constantly uploading a new texture to OpenGL throughout the > animation. > > > Diffs > ----- > > .reviewboardrc 804529c > src/declarativeimports/core/CMakeLists.txt 9b3313d > src/declarativeimports/core/fadingnode.cpp PRE-CREATION > src/declarativeimports/core/fadingnode_p.h PRE-CREATION > src/declarativeimports/core/iconitem.h 92a5233 > src/declarativeimports/core/iconitem.cpp 9cb487c > > Diff: https://git.reviewboard.kde.org/r/116024/diff/ > > > Testing > ------- > > Test app: http://paste.kde.org/pl5pwdnel > > Test app shows for lots of icons a decrease from 40 -> 27Mb > apitrace has a lot fewer calls to glTexImage2D > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
