> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 259 > > <https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line259> > > > > This means we'll end up with a KCM to change icons that does nothing. > > That sounds bad? > > > > I was under the impression that we were using L&F to get the default > > icon set if one is not set.
hmm, maybe there is some error in logic of readConfigValue.. but is supposed to first read from the user configured entry in kdeglobals, then if is empty try to read from lnf, and lastly if that's empty too read from the hardcoded parameter, so the user configured value should still win? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/#review63781 ----------------------------------------------------------- On July 29, 2014, 4:22 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119534/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 4:22 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: frameworkintegration > > > Description > ------- > > there will be support for some kind of "mega theme" that besides providing > files for splashscreen, lockscreen etc, will define what defaults to use > among icons, colors, fonts etc. > > This is a first start of it for reading the defaults. The theme file is > stored in a plasma package, but the patch resolves the correct path by hand, > not requiring linking to libplasma. > right now only a couple of settings is used, mostly to see if the direction > is good. > > > Diffs > ----- > > src/platformtheme/khintssettings.h 57f1864 > src/platformtheme/khintssettings.cpp 104f77c > > Diff: https://git.reviewboard.kde.org/r/119534/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
