> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote:
> >

Another thing I would like an opinion on, is about the color scheme:
right now it searches for a configured color scheme name, then searches in the 
package a file with the same name as the color scheme name.
I was thinking it may be prettier to have the colors file optionally provided 
by the package as just "colors" or some fixed name?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/#review63781
-----------------------------------------------------------


On Aug. 4, 2014, 3:18 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119534/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 3:18 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> there will be support for some kind of "mega theme" that besides providing 
> files for splashscreen, lockscreen etc, will define what defaults to use 
> among icons, colors, fonts etc.
> 
> This is a first start of it for reading the defaults. The theme file is 
> stored in a plasma package, but the patch resolves the correct path by hand, 
> not requiring linking to libplasma.
> right now only a couple of settings is used, mostly to see if the direction 
> is good.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.h 57f1864 
>   src/platformtheme/khintssettings.cpp f9e068d 
> 
> Diff: https://git.reviewboard.kde.org/r/119534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to