----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66226 -----------------------------------------------------------
Ship it! Woo, I like patches with lots of red :) Looks good to me. - David Edmundson On Sept. 11, 2014, 10:28 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120141/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 10:28 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This patch cleans up the Applet Configuration sidebar. > > - Get rid of lagging-behind highlight > - Provide hover feedback > - Get rid of radius (Breeze is blocky, and it was hardcoded anyway) > - Fix some brokenness (Column in Item in Flickable in ScrollView) and some > anchoring + width set > > Did not add the white background we have in the Widgets variant as imho that > would break Plasma's sexyness. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 87f40ce > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fd7b88c > > Diff: https://git.reviewboard.kde.org/r/120141/diff/ > > > Testing > ------- > > Works as it did before - just more beautiful :) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel