> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > <https://git.reviewboard.kde.org/r/120141/diff/1/?file=311519#file311519line75> > > > > this may pose a performance problem, don't bind things to properties > > that have an animation, also when opacity=0 visible is considered false, so > > you can just remove the line > > Kai Uwe Broulik wrote: > Ah, thanks for the tip.
Actually, visible and opacity are independent in QtQuick 2. opacity == 0 doesn't imply visible == false anymore, for details, see http://qt-project.org/doc/qt-5/qtquick-porting-qt5.html IOW, Kai's code is correct. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66228 ----------------------------------------------------------- On Sept. 11, 2014, 10:28 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120141/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 10:28 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This patch cleans up the Applet Configuration sidebar. > > - Get rid of lagging-behind highlight > - Provide hover feedback > - Get rid of radius (Breeze is blocky, and it was hardcoded anyway) > - Fix some brokenness (Column in Item in Flickable in ScrollView) and some > anchoring + width set > > Did not add the white background we have in the Widgets variant as imho that > would break Plasma's sexyness. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 87f40ce > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fd7b88c > > Diff: https://git.reviewboard.kde.org/r/120141/diff/ > > > Testing > ------- > > Works as it did before - just more beautiful :) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
