> On Sept. 11, 2014, 4:36 nachm., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDialog this still > is ... color scheme, animations, selection delegate, page switch animation, > etc, it's all very inconsistent.
Weird. The width is based on gridUnit for quite some time now. I didn't "deliberately" break that - does it work without this patch? We could make the background white but the subtle animation and stuff should stay. There's no QtQuick version of that item yet. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66282 ----------------------------------------------------------- On Sept. 11, 2014, 12:56 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120141/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 12:56 nachm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This patch cleans up the Applet Configuration sidebar. > > - Get rid of lagging-behind highlight > - Provide hover feedback > - Get rid of radius (Breeze is blocky, and it was hardcoded anyway) > - Fix some brokenness (Column in Item in Flickable in ScrollView) and some > anchoring + width set > > Did not add the white background we have in the Widgets variant as imho that > would break Plasma's sexyness. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 87f40ce > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fd7b88c > > Diff: https://git.reviewboard.kde.org/r/120141/diff/ > > > Testing > ------- > > Works as it did before - just more beautiful :) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
