----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ -----------------------------------------------------------
(Updated Nov. 25, 2014, 3:11 p.m.) Review request for Plasma. Changes ------- I have updated the review request. As it has been discussed, the timeline will get its data from the QueryResultsModel (which lives inside the Baloo repo.) and it will generate the timeline. Repository: plasma-mobile Description ------- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs (updated) ----- components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION CMakeLists.txt 9466447 Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing ------- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
