> On Nov. 28, 2014, 11:26 a.m., Vishesh Handa wrote: > > components/timelinemodel/timelinemodel.cpp, line 136 > > <https://git.reviewboard.kde.org/r/120777/diff/3/?file=330748#file330748line136> > > > > Has this been tested? > > > > This assert would be true when m_level is Month or Day.
Yeap, i missed this one. > On Nov. 28, 2014, 11:26 a.m., Vishesh Handa wrote: > > components/timelinemodel/timelinemodel.h, line 32 > > <https://git.reviewboard.kde.org/r/120777/diff/3/?file=330747#file330747line32> > > > > I also just realized that the start and end date are QStrings, and not > > QDates. > > > > Is it easier to work with strings in QML? I used strings because with dates i think that we making our component more complicated without any reason (based on this page http://qt-project.org/doc/qt-5/qml-qtqml-date.html). Also we will have to convert the QDate into a QString, in order to use it inside the searchString. But if you want prefer the QDate, its fine for me. I can change it :) - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review71055 ----------------------------------------------------------- On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120777/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 6:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mobile > > > Description > ------- > > At the moment, Baloo doesn't provide a timeline, which is something that we > need for the activefilebrowser. > So this new component, is introducing support for the timeline. > > Notes > === > > * Baloocloud component contains the org.kde.baloo component inside it.The > reason behind that, is that the implementation for the timeline is kind of > terible because of its perfomance. > * I have put the new component inside the plasma-mobile repository, for the > above reason. But if the Baloo team, wants it inside the baloo repo then i > can move it. I am fine with both approaches (keep it here or in the baloo > repository. > * If someone has a better idea about the implementation, the pls shoot :) > > > > Diffs > ----- > > CMakeLists.txt 9466447 > components/CMakeLists.txt 536b60e > components/timelinemodel/CMakeLists.txt PRE-CREATION > components/timelinemodel/qmldir PRE-CREATION > components/timelinemodel/timelinemodel.h PRE-CREATION > components/timelinemodel/timelinemodel.cpp PRE-CREATION > components/timelinemodel/timelineplugin.h PRE-CREATION > components/timelinemodel/timelineplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120777/diff/ > > > Testing > ------- > > Everything looks ok. The performance is not bad, except from the fact that > the implementation is a bit of hackish... > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
