----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review72659 -----------------------------------------------------------
Then Qt5Webkit should be marked as optional through the set_package_properties(). To be honest, I'm not thrilled about having many ways to configure these things, because sooner or later somebody will end up compiling Plasma without qtwebkit by mistake and then he'll miss drkonqi, but well, building qtwebkit sure is a PITA, so won't oppose. - Aleix Pol Gonzalez On Dec. 28, 2014, 6:16 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121718/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2014, 6:16 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Only drkonqi and systemmonitor depend on it. > > (systemmonitor uses libksysguard's processui lib, which is not installed > by libksysguard if webkit is not found) > > > Diffs > ----- > > CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 > drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67 > > Diff: https://git.reviewboard.kde.org/r/121718/diff/ > > > Testing > ------- > > Compiling without qt5 webkit. > > > Thanks, > > David Faure > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
