> On Dec. 29, 2014, 4:40 a.m., Aleix Pol Gonzalez wrote: > > Then Qt5Webkit should be marked as optional through the > > set_package_properties(). > > > > To be honest, I'm not thrilled about having many ways to configure these > > things, because sooner or later somebody will end up compiling Plasma > > without qtwebkit by mistake and then he'll miss drkonqi, but well, building > > qtwebkit sure is a PITA, so won't oppose. > > Marco Martin wrote: > anyways, this webkit dependency should be removed sooner than later no? > so making it optional would be a good first step. > > Marco Martin wrote: > also, what exactly drkonqui uses qtwebkit for? > > Aleix Pol Gonzalez wrote: > > /home/kde-devel/frameworks/plasma-workspace/drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp > uses KWebView for showing a report that the bug has been filled. > > How would you remove the dependency? With QtWebEngine? Isn't it the same > thing? > > David Faure wrote: > If it's just to open a URL at the end of process, why not just launch a > web browser?
I didn't really think it through, maybe it's a good solution. It's derailing from the original patch anyway. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review72659 ----------------------------------------------------------- On Dec. 28, 2014, 6:16 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121718/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2014, 6:16 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Only drkonqi and systemmonitor depend on it. > > (systemmonitor uses libksysguard's processui lib, which is not installed > by libksysguard if webkit is not found) > > > Diffs > ----- > > CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 > drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67 > > Diff: https://git.reviewboard.kde.org/r/121718/diff/ > > > Testing > ------- > > Compiling without qt5 webkit. > > > Thanks, > > David Faure > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
