----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122928/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- This is a followup on my yesterday's patch. It changes value of "error" in applicationjobs dataengine to uint KJob::error and adds a new value "errorText" = QString KJob::errorText. This change makes it possible for notifications applet to detect job error even when job have empty errorText. This also changes the behavior that no notification is displayed for jobs cancelled by user (eg. cancelled rename, overwrite, ...). I think it is also no longer needed to store cancelledJobs property in Jobs.qml, because ERR_USER_CANCELED = KJob::KilledJobError, but that would need more testing. I can open a new review for that. Diffs ----- applets/notifications/package/contents/ui/Jobs.qml e8a4748 dataengines/applicationjobs/kuiserverengine.h c03b070 dataengines/applicationjobs/kuiserverengine.cpp e0b2ced kuiserver/jobview.h b78ad14 kuiserver/jobview.cpp 4c76c5a Diff: https://git.reviewboard.kde.org/r/122928/diff/ Testing ------- Cancelling a file overwrite no longer shows any notification. Thanks, David Rosca
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
