----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122928/#review77410 -----------------------------------------------------------
+1 from me. Thanks for fixing this decade old annoyance! > I think it is also no longer needed to store cancelledJobs property in > Jobs.qml Yes, this cancelledJob thing was just a workaround to alleviate the problem, so at least when you cancelled a job from within the plasmoid, it wouldn't show a message. applets/notifications/package/contents/ui/Jobs.qml <https://git.reviewboard.kde.org/r/122928/#comment53156> Could be simplified to > message = errorText || message or perhaps even further down > body: errorText || message in case errorText is empty when there hasn't been one - Kai Uwe Broulik On März 13, 2015, 8:39 vorm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122928/ > ----------------------------------------------------------- > > (Updated März 13, 2015, 8:39 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This is a followup on my yesterday's patch. > > It changes value of "error" in applicationjobs dataengine to uint KJob::error > and adds a new value "errorText" = QString KJob::errorText. > This change makes it possible for notifications applet to detect job error > even when job have empty errorText. > > This also changes the behavior that no notification is displayed for jobs > cancelled by user (eg. cancelled rename, overwrite, ...). > > I think it is also no longer needed to store cancelledJobs property in > Jobs.qml, because ERR_USER_CANCELED = KJob::KilledJobError, but that would > need more testing. I can open a new review for that. > > > Diffs > ----- > > applets/notifications/package/contents/ui/Jobs.qml e8a4748 > dataengines/applicationjobs/kuiserverengine.h c03b070 > dataengines/applicationjobs/kuiserverengine.cpp e0b2ced > kuiserver/jobview.h b78ad14 > kuiserver/jobview.cpp 4c76c5a > > Diff: https://git.reviewboard.kde.org/r/122928/diff/ > > > Testing > ------- > > Cancelling a file overwrite no longer shows any notification. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
