> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and 
> > > in how much time).
> > 
> > What's the benefit to the user of merging this version now?
> 
> Marco Martin wrote:
>     none.
>     not too much pain as well tough.
>     all of them have to eventually be ported tough and in order to get done, 
> one has to.. do it
> 
> Eike Hein wrote:
>     > all of them have to eventually be ported tough and in order to get 
> done, one has to.. do it
>     
>     I'm just not a big fan of putting transitional pain (worse UI from a 
> weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
> ... right now, Qt Quick has worse performance, no keyboard accelerator 
> management, no form layouts, limited widgets, some visual problems, etc. - 
> It's true of course that using it builds greater pressure to get it fixed, 
> but are we *certain* that actively hurting the quality of our releases is the 
> only path available?

bah, right now accelerators and tab focus kinda works in that module..
still kinda, but again, if the decision is to go in that direction, of which i 
remeber it was talked about and decided, otherwise I wouldn't have wasted two 
days on it ;)
Now, I'm fine if now we decide to not port modules, but most of them kindof 
have to be redone anyways, and I would prefer reding them once rather than 
twice.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
-----------------------------------------------------------


On April 23, 2015, 2:08 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is more an experiment on how much modules can be closely ported (and in 
> how much time).
> the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the 
> QtQuickControls ComboBox being very limited and without a customizable 
> delegate.
> all the other functions such as add/remove/ghns seems to work well
> 
> 
> Diffs
> -----
> 
>   applets/icontasks/metadata.desktop f0b237c 
>   containments/folder/metadata.desktop a6d08a7 
>   kcms/access/kcmaccess.desktop 825b6d7 
>   kcms/baloo/kcm_baloofile.desktop 2eee6fc 
>   kcms/cursortheme/CMakeLists.txt 83f3ba2 
>   kcms/cursortheme/Messages.sh 79450c7 
>   kcms/cursortheme/cursortheme.desktop f443208 
>   kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION 
>   kcms/cursortheme/kcmcursortheme.h d9e32b2 
>   kcms/cursortheme/kcmcursortheme.cpp 44576ff 
>   kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION 
>   kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION 
>   kcms/cursortheme/package/metadata.desktop PRE-CREATION 
>   kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 
>   kcms/cursortheme/xcursor/itemdelegate.cpp e737005 
>   kcms/cursortheme/xcursor/previewwidget.h 4a11e2d 
>   kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 
>   kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 
>   kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 
>   kcms/cursortheme/xcursor/thememodel.h bcf046a 
>   kcms/cursortheme/xcursor/thememodel.cpp 4e4647f 
>   kcms/cursortheme/xcursor/themepage.h 98c69fd 
>   kcms/cursortheme/xcursor/themepage.cpp 687bd65 
>   kcms/cursortheme/xcursor/themepage.ui 6efe60b 
>   kcms/desktoppaths/desktoppath.desktop eb2fad5 
>   kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 
>   kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c 
>   kcms/lookandfeel/package/metadata.desktop 6595d6e 
>   kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 
>   kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f 
>   kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e 
>   kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 
>   kcms/useraccount/kcm_useraccount.desktop 46ef110 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 
> 89d7fc3 
> 
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> cursorskcm.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to