> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tough. > all of them have to eventually be ported tough and in order to get done, > one has to.. do it > > Eike Hein wrote: > > all of them have to eventually be ported tough and in order to get > done, one has to.. do it > > I'm just not a big fan of putting transitional pain (worse UI from a > weaker toolkit) on the user when there's an opportunity to avoid it, I guess > ... right now, Qt Quick has worse performance, no keyboard accelerator > management, no form layouts, limited widgets, some visual problems, etc. - > It's true of course that using it builds greater pressure to get it fixed, > but are we *certain* that actively hurting the quality of our releases is the > only path available? > > Marco Martin wrote: > bah, right now accelerators and tab focus kinda works in that module.. > still kinda, but again, if the decision is to go in that direction, of > which i remeber it was talked about and decided, otherwise I wouldn't have > wasted two days on it ;) > Now, I'm fine if now we decide to not port modules, but most of them > kindof have to be redone anyways, and I would prefer reding them once rather > than twice. > > David Edmundson wrote: > > It's true of course that using it builds greater pressure to get it > fixed, but are we certain that actively hurting the quality of our releases > is the only path available? > > It's not as simple as saying using new stuff /will/ hurt the quality > compared to the current state. > > This KCM wouldn't use form layouts, or any special widgets that we don't > have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by > the time we finish with this, I think we can make it just as perfect /and/ > progress our QQC integration at the same time. > > Also it's not like these KCMs are truly perfect as-is. There are 8 open > bugs on the cursor KCM. I'd like to think paying some attention to these KCMs > will fix some of them. > > I do completely agree with you that users shouldn't be hurt by porting > efforts and we should have an absolutely no regressions at all policy before > merging, with no excuses about limitations in QQC. > > Martin Gräßlin wrote: > I agree with David that we also should see this as a chance. For example > I always wondered why there is this "strange" preview area on the top, > instead of just previewing all cursors in the list directly. With QQC that > becomes quite easier and removes the "it's probably because it would be a > nightmare with delegates". > > Marco Martin wrote: > having all the previews inline could probably be simpler since i could > perhaps avoid a custom qquickpainteditem.. however, it would look very > crowded i think? > > Martin Gräßlin wrote: > maybe only show them for the selected or on hover? > > Marco Martin wrote: > this is very quick and dirty: > http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png > > with very big delegates, it almost looks nice :) > > Sebastian Kügler wrote: > I quite like it. Also, it's really not necessary to be able to view 5 or > more themes at the same time, this makes comparison already a lot easier. > > Marco Martin wrote: > this is with a better layout: > http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png > there is still one thing that doesn't logically work too much, that is > the size combo box, since it depends from the theme selected (not all themes > have all the same sizes available) so that may have to be made inline as > well, not sure if it would work well tough > > Martin Gräßlin wrote: > > so that may have to be made inline as well, not sure if it would work > well tough > > Given that it already has this "Available size", I think it could be a > neat idea to morph it into the delegate. > > (o) Resolution Dependent > (o) |Dropdown| available sizes
> For example I always wondered why there is this "strange" preview area on the > top, instead of just previewing all cursors in the list directly. With QQC > that becomes quite easier and removes the "it's probably because it would be > a nightmare with delegates". * So that the appearance and behavior of the KCM is consistent with that of the icon theme KCM. * So that the listview looks and behaves identically to other listviews. * To enable the user to get a quick overview of the installed themes without having to scroll. * Each item in the listview provides three key points of data so as to not overwhelm the user with information; a single large image of the most important cursor, the name of the theme, and finally a short description. Every design decision was make after careful consideration, and after studying the user interface guidelines for other desktops. (The KDE HIG doesn't cover these types of controls). - Fredrik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79374 ----------------------------------------------------------- On April 24, 2015, 3:10 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123473/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 3:10 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This is more an experiment on how much modules can be closely ported (and in > how much time). > the mouse theme kcm should be pretty much feature complete. > the main problem is the size combobox missing the cursor image due to the > QtQuickControls ComboBox being very limited and without a customizable > delegate. > all the other functions such as add/remove/ghns seems to work well > > > Diffs > ----- > > applets/icontasks/metadata.desktop f0b237c > containments/folder/metadata.desktop a6d08a7 > kcms/access/kcmaccess.desktop 825b6d7 > kcms/baloo/kcm_baloofile.desktop 2eee6fc > kcms/cursortheme/CMakeLists.txt 83f3ba2 > kcms/cursortheme/Messages.sh 79450c7 > kcms/cursortheme/cursortheme.desktop f443208 > kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION > kcms/cursortheme/kcmcursortheme.h d9e32b2 > kcms/cursortheme/kcmcursortheme.cpp 44576ff > kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION > kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION > kcms/cursortheme/package/metadata.desktop PRE-CREATION > kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 > kcms/cursortheme/xcursor/itemdelegate.cpp e737005 > kcms/cursortheme/xcursor/previewwidget.h 4a11e2d > kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 > kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 > kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 > kcms/cursortheme/xcursor/thememodel.h bcf046a > kcms/cursortheme/xcursor/thememodel.cpp 4e4647f > kcms/cursortheme/xcursor/themepage.h 98c69fd > kcms/cursortheme/xcursor/themepage.cpp 687bd65 > kcms/cursortheme/xcursor/themepage.ui 6efe60b > kcms/desktoppaths/desktoppath.desktop eb2fad5 > kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 > kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c > kcms/lookandfeel/package/metadata.desktop 6595d6e > kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 > kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f > kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e > kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 > kcms/useraccount/kcm_useraccount.desktop 46ef110 > layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop > 89d7fc3 > > Diff: https://git.reviewboard.kde.org/r/123473/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > cursorskcm.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
