----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80249 -----------------------------------------------------------
src/kdeclarative/qmlobject.h (line 81) <https://git.reviewboard.kde.org/r/123735/#comment55043> Empty comment? src/kdeclarative/qmlobjectsharedengine.cpp (line 65) <https://git.reviewboard.kde.org/r/123735/#comment55044> Maybe it should better use Q_GLOBAL_STATIC? - Aleix Pol Gonzalez On May 12, 2015, 5:35 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123735/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 5:35 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > to make easier doing applications like plasma that use a lot of qml to have a > single engine make a subclass of QmlObject called QmlObjectSharedEngine that > has a single, static QQmlEngine > > > Diffs > ----- > > src/kdeclarative/CMakeLists.txt d73bff0 > src/kdeclarative/kdeclarative.cpp b3906e2 > src/kdeclarative/qmlobject.h f26b67d > src/kdeclarative/qmlobject.cpp c483665 > src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION > src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123735/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel