> On May 12, 2015, 3:52 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 62 > > <https://git.reviewboard.kde.org/r/123735/diff/2/?file=368373#file368373line62> > > > > this needs to be initialised.
line 65 QQmlEngine *QmlObjectSharedEnginePrivate::s_engine = 0; > On May 12, 2015, 3:52 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 69 > > <https://git.reviewboard.kde.org/r/123735/diff/2/?file=368373#file368373line69> > > > > I'm not sure the ownership on the context is right. > > > > I think we want the context to last for the lifespan of the > > QmlObjectSharedEngine (this), currently it's the lifespan of the enitre app if i parent it it crashes on initialization, if i delete the context on the qmlobject destruction, it seems to work fine > On May 12, 2015, 3:52 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobject.cpp, line 176 > > <https://git.reviewboard.kde.org/r/123735/diff/2/?file=368371#file368371line176> > > > > if we're using the shared engine we end up not setting the incubation > > controller. I don't know what difference that will make? ah, even if now is sync, the incubator is still needed for the initialProperties paramenter, added it - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80244 ----------------------------------------------------------- On May 12, 2015, 4:05 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123735/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 4:05 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > to make easier doing applications like plasma that use a lot of qml to have a > single engine make a subclass of QmlObject called QmlObjectSharedEngine that > has a single, static QQmlEngine > > > Diffs > ----- > > src/kdeclarative/CMakeLists.txt d73bff0 > src/kdeclarative/kdeclarative.cpp b3906e2 > src/kdeclarative/qmlobject.h f26b67d > src/kdeclarative/qmlobject.cpp c483665 > src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION > src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123735/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
