> On June 14, 2015, 9:18 a.m., Kai Uwe Broulik wrote:
> > Wouldn't that cause strange visual effects for the slideshow, when both 
> > images fade at the same time?
> > 
> > Did you try setting visible to false rather than opacity to zero? Really 
> > strange bug, we set opacity to zero and unset the source, so there's two 
> > things that should make it disappear :(

No, the visual effect of the slideshow is fine.  At least, it looks the same as 
it ever did.  :-)

Setting visible to false doesn't change anything.  I believe that the image is 
"gone", but the screen does not get repainted in that area so it stays there.


- William


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124093/#review81459
-----------------------------------------------------------


On June 14, 2015, 9:15 a.m., William Lieurance wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124093/
> -----------------------------------------------------------
> 
> (Updated June 14, 2015, 9:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Moving the opacity change from a ScriptAction to a parallel OpacityAnimator.  
> That seems to cause a repaint in whatever weird environment happens to be the 
> root of this bug.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml 
> 23d23ff7003488d74ece0d70a1c68d129f282c75 
> 
> Diff: https://git.reviewboard.kde.org/r/124093/diff/
> 
> 
> Testing
> -------
> 
> See conversation on the bug page 
> (https://bugs.kde.org/show_bug.cgi?id=345405).  This code should work 
> identically to the current script, but for whatever reason it causes a 
> repaint to be issued correctly whereas the other does not.
> 
> 
> Thanks,
> 
> William Lieurance
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to