> On June 15, 2015, 5:11 p.m., David Edmundson wrote: > > I'm still not super convinced we're not just working round a bug, but I > > couldn't make a test case / fix it any other way after a solid hour of > > trying. > > > > Effect still looks good, if not better so I'm OK shipping this. I'll merge > > it this evening. > > William Lieurance wrote: > Hi there. I noticed that this change hadn't been merged. Please let me > know if there's anything I need to do. Thanks!
Thanks for reminding me. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/#review81485 ----------------------------------------------------------- On July 7, 2015, 4:26 p.m., William Lieurance wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124093/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 4:26 p.m.) > > > Review request for Plasma. > > > Bugs: 345405 > https://bugs.kde.org/show_bug.cgi?id=345405 > > > Repository: plasma-workspace > > > Description > ------- > > Moving the opacity change from a ScriptAction to a parallel OpacityAnimator. > That seems to cause a repaint in whatever weird environment happens to be the > root of this bug. > > > Diffs > ----- > > wallpapers/image/imagepackage/contents/ui/main.qml > 23d23ff7003488d74ece0d70a1c68d129f282c75 > > Diff: https://git.reviewboard.kde.org/r/124093/diff/ > > > Testing > ------- > > See conversation on the bug page > (https://bugs.kde.org/show_bug.cgi?id=345405). This code should work > identically to the current script, but for whatever reason it causes a > repaint to be issued correctly whereas the other does not. > > > Thanks, > > William Lieurance > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
