----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/ -----------------------------------------------------------
(Updated June 23, 2015, 11:42 a.m.) Review request for Plasma. Changes ------- Here's a patch removing the icon space altogether when no icon is set, see the second screenshot. Personally I think it looks weird and don't like it too much, but if the vdg thinks this makes sense, I'll go for it. Repository: plasma-workspace Description ------- Currently there's none and if there's just a summary text ($ notify-send text), the notification popup looks strange. Adding the default icon makes it look more consistent and not totally-out-of-place-command-line-notification. Diffs (updated) ----- applets/notifications/package/contents/ui/NotificationItem.qml 9e413f9 Diff: https://git.reviewboard.kde.org/r/124151/diff/ Testing ------- See screenshot File Attachments (updated) ---------------- Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png No icon notification https://git.reviewboard.kde.org/media/uploaded/files/2015/06/23/06c769be-b5fc-4360-9aac-6f3179601d92__notifications-layout1.png Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
