> On Aug. 1, 2015, 11:48 a.m., Martin Klapetek wrote: > > shell/main.cpp, line 44 > > <https://git.reviewboard.kde.org/r/124576/diff/1/?file=389034#file389034line44> > > > > Just now I've read the actual message, "Please confirm your drivers" > > has two issues - a) it should mention graphics driver (OpenGL may not be > > that connection that users would make) and b) "confirm" suggests there's a > > button which will continue with the launching, kinda like "This video > > contains violence, please confirm you are over 15 [I am, let me in] [I'm > > not]", but this is not the case. > > > > That said, I believe that "Please check that your graphics drivers are > > installed correctly" would read better to the users. > > > > Thinking a bit more about it (though for later patch), maybe it should > > also offer to log out or open Konsole? Because this way you're just left > > out with black screen, unable to do anything.
Done. >Thinking a bit more about it (though for later patch), maybe it should also >offer to log out or open Konsole? Yeah, might be good. Would also be nice to have another attempt at launching the shell using QT_XCB_FORCE_SOFTWARE_OPENGL=1 - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review83289 ----------------------------------------------------------- On Aug. 1, 2015, 12:08 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124576/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2015, 12:08 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Show a dialog if Plasma failed to create an OpenGL Context. > > remove that "shutup" option we had, it was a workaround for an issue with > Qt5.1 spewing warnings constantly. > > > Diffs > ----- > > shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f > > Diff: https://git.reviewboard.kde.org/r/124576/diff/ > > > Testing > ------- > > Normal plasma is the same as before. > I don't know how to break my openGL, but placing a random qFatal() with the > same error message got my dialog perfectly. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
