----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125719/#review87235 -----------------------------------------------------------
I'm madly sorry for taking mistake. I've found a critical regression by testing again. I've already fixed it by the commit below. https://quickgit.kde.org/?p=kdeclarative.git&a=commit&h=1c3f42afe17cc090372eaf45647d71495de12c19 I'm sorry again my wrong test process... - Takahiro Hashimoto On 10月 22, 2015, 7:48 a.m., Takahiro Hashimoto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125719/ > ----------------------------------------------------------- > > (Updated 10月 22, 2015, 7:48 a.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Now QuickViewSharedEngine view size is initialized with its rootObject size > in QuickViewSharedEnginePrivate::executionFinished(). > > In the case of setting its size before completing > QuickViewSharedEnginePrivate::executionFinished(), it is forcely overwrote > with rootObject size unexpectedly. > > This problem happens when running ksplashqml on higher or lower resolution > screen than breeze background image size(1920x1080) (see attached screenshot > executing "ksplashqml --test" at 3200x1800 screen) > > I think it would be better that the view size which is specified by manual > precede default size initialization process. Adjusting view and object size > can be done by syncResizeMode() in > QuickViewSharedEnginePrivate::executionFinished(). > > This patch make the view size adjust to its rootObject size when view size > isEmpty(). > > AFAIK, QuickViewSharedEngine is now used by screenlocker greeter and > ksplashqml. I cannot imagine this change affect another use cases. Please let > me have any advice:) > > > Diffs > ----- > > src/quickaddons/quickviewsharedengine.cpp b57d7dc > > Diff: https://git.reviewboard.kde.org/r/125719/diff/ > > > Testing > ------- > > apply this patch and confirmed ksplashqml content was adjusted to screen size > correctly. > screenlocker remain working fine to me. > > > File Attachments > ---------------- > > ksplash_incorrect_resolution.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/20/3775b064-1463-478b-888a-f4d173ec696c__ksplash_incorrect_resolution.png > > > Thanks, > > Takahiro Hashimoto > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
