> On Nov. 8, 2015, 3:37 nachm., Thomas Pfeiffer wrote: > > Showing it always does make sense as long as it affects only a few > > Plasmoids, yes. > > About the undo: I'm wondering if it might make sense - for consistency's > > sake - to do the undo mechanism similar to undoing the removal of a > > Plasmoid from the desktop/panel, i.e. via a button in a notification > > confirming about the completed deinstallation? > > Kai Uwe Broulik wrote: > So you want the thing to be removed from the list immediately when I > press delete and then we spawn a notification on the opposite side of the > screen? Doesn't sound too usable for me given the widget explorer is always > on the left side of the screen. > > Marco Martin wrote: > not so sure it it would work there.. > maybe just adding an overlay to the applet thumbnail a "deleted" with and > undo button and actually uninstall all of them when the widget expolorer gets > closed (again, not sure is a good idea) > > Kai Uwe Broulik wrote: > So basically like it is now, except I add an overlay saying "Uninstalled" > with a more prominent Undo button. > > Thomas Pfeiffer wrote: > The reason why I suggested doing it like we do with Plasmoids is simply > consistency. The more knowledge users can transfer from one area to another, > the better. Undoing an uninstall should not be such a common thing (unless > you are a user who constantly clicks the wrong things), so I believe that > consistency is more important than comfort. > > That said, Marco's suggestions makes sense to me as well. It would look > similar to the Plasmoid mechanism while keeping in the same place. > > The downside I see is that if one clicks uninstall, closes the widget > explorer (because one thinks the task is complete) and in the next split > second realized "Oh fuck, that was the wrong one!", it's too late. With a > notification, one has much more time to undo the action. > > Martin Klapetek wrote: > Ideally there should be a timeout, just like with the notification, > before it disappears. Like for 1 minute, it will stay there and then > disappear altogether. > > Thomas Pfeiffer wrote: > So re-opening the widget explorer during that timeout would still shout > the undo button? > That would work.
If I stored the pending deletions in the Desktop.qml rather than the WidgetExplorer.qml (not sure I want to do that though) they would survive the widget explorer closing. I would not do separate timers (to not complicate things), though, but always 1 minute after the last widget I deleted (and restart the timer if you delete another one in the meantime) it would remove all pending ones. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125991/#review88162 ----------------------------------------------------------- On Nov. 8, 2015, 12:23 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125991/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 12:23 vorm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-desktop > > > Description > ------- > > The no longer enabled tooltip also contained the uninstall button. This > restores the uninstall functionality similar to the wallpaper dialog. > > User-installed applets get an uninstall button. I chose to always show it > rather than on hover since only a few applets are likely to be uninstallable > and I don't want to play the guessing-game, perhaps we should introduce a > filter for "User-installed applets" similar to the (less useful) "running" > ones. Clicking the button will queue the uninstallation which can be > cancelled anytime the dialog is still opened. As soon as the dialog closes, > the actual uninstall is executed. > > Multiple applets can be enqueued simultaneously. > > > Diffs > ----- > > desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 > desktoppackage/contents/explorer/WidgetExplorer.qml af27229 > > Diff: https://git.reviewboard.kde.org/r/125991/diff/ > > > Testing > ------- > > Installed plasmoid through drag and drop, uninstalled after fixing an > uninstall bug (Review 125990) > > The tooltip says "Undo uninstall". I just noticed I should probably fade the > applet name too. > > > File Attachments > ---------------- > > Uninstall before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png > Undo uninstall > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
