-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 10:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
-------

Submitted with commit cc1a9b52119f4fa441dbc08d0188c03688d9768b by Kai Uwe 
Broulik to branch master.


Repository: plasma-desktop


Description
-------

The no longer enabled tooltip also contained the uninstall button. This 
restores the uninstall functionality similar to the wallpaper dialog.

User-installed applets get an uninstall button. I chose to always show it 
rather than on hover since only a few applets are likely to be uninstallable 
and I don't want to play the guessing-game, perhaps we should introduce a 
filter for "User-installed applets" similar to the (less useful) "running" 
ones. Clicking the button will queue the uninstallation which can be cancelled 
anytime the dialog is still opened. As soon as the dialog closes, the actual 
uninstall is executed.

Multiple applets can be enqueued simultaneously.


Diffs
-----

  desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
  desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
  desktoppackage/contents/views/Desktop.qml b555fea 

Diff: https://git.reviewboard.kde.org/r/125991/diff/


Testing
-------

Installed plasmoid through drag and drop, uninstalled after fixing an uninstall 
bug (Review 125990)

The tooltip says "Undo uninstall". I just noticed I should probably fade the 
applet name too.


File Attachments
----------------

Uninstall before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
Undo uninstall
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png


Thanks,

Kai Uwe Broulik

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to