> On Jan. 15, 2016, 3:20 nachm., Jan Grulich wrote: > > Looks good to me, maybe just change what I pointed out (storing just UUIDs > > as strings instead active connections). I don't have time right now to test > > it, but I trust you that it works. > > > > Looking only for active connections would probably require increasing the > > time at least to 10 seconds, just leave it as it is for now.
Okay, given when activating a connection fails it will tell you, it's not ad bad if we don't show the not connected notification then. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91150 ----------------------------------------------------------- On Jan. 15, 2016, 3:03 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126748/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 3:03 nachm.) > > > Review request for Plasma, Jan Grulich and Lamarque Souza. > > > Repository: plasma-nm > > > Description > ------- > > It's quite natural that the connection goes away when we're about to suspend > :) Watch for this and then don't emit the notification. > > > Diffs > ----- > > kded/networkmanagement.notifyrc 7ce437c > kded/notification.h 9b8b51a > kded/notification.cpp 231d69e > > Diff: https://git.reviewboard.kde.org/r/126748/diff/ > > > Testing > ------- > > While I still think Plasma-NM is waaaaaay too verbose about everything, at > least it doesn't tell me that I just disconnected when I suspend. > > I still get the notification when I turn off Wifi manually. > I also still get the notification that I'm connected again shortly after > resuming. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
