-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91598
-----------------------------------------------------------


Ship it!




Ship It!

- Lamarque Souza


On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 3:03 p.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -----
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> -------
> 
> While I still think Plasma-NM is waaaaaay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to