> On March 8, 2016, 8:21 a.m., Xuetian Weng wrote: > > kcms/touchpad/src/kcm/ui/scroll.ui, line 138 > > <https://git.reviewboard.kde.org/r/127306/diff/1/?file=448479#file448479line138> > > > > I just wonder if plasma 5.6 is in string freeze or not.
Ok plasma 5.6 is already string freeze. You may only commit the accelerator change only to master. - Xuetian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/#review93282 ----------------------------------------------------------- On March 7, 2016, 7:47 p.m., Rajeesh K V wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127306/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 7:47 p.m.) > > > Review request for Plasma, David Edmundson and Xuetian Weng. > > > Bugs: 359460 > https://bugs.kde.org/show_bug.cgi?id=359460 > > > Repository: plasma-desktop > > > Description > ------- > > Fixes few things: > 1. Remove redefined members of parent class XlibTouchpad from > SynapticsTouchpad class fixing wrong scroll delta values. > 2. Enlarge vertical,horizontal&circular scroll delta and maxtapmove allowing > value more than 100. The amx value chosen arbitrarily is 500. > > I would like to get this fix in 5.6 final. > > > Diffs > ----- > > kcms/touchpad/src/backends/x11/synapticstouchpad.h de75125 > kcms/touchpad/src/backends/x11/synapticstouchpad.cpp 1e01894 > kcms/touchpad/src/kcm/touchpad.kcfg d4d127c > kcms/touchpad/src/kcm/ui/scroll.ui d1c2f76 > kcms/touchpad/src/kcm/ui/tap.ui 389db5e > > Diff: https://git.reviewboard.kde.org/r/127306/diff/ > > > Testing > ------- > > Built the RPM, compile tested. Bug reporters confirm patch fixes the issue. > > > Thanks, > > Rajeesh K V > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel