----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/#review93314 -----------------------------------------------------------
kcms/touchpad/src/backends/x11/synapticstouchpad.h <https://git.reviewboard.kde.org/r/127306/#comment63631> My initial intention is to move this synaptics member into SynaptcsTouchpad but later I found they are accessed in XlibTouchpad directly so I move them to XlibTouchpad again for now. (and forgot to delete thoses ones in SynatpcsTouchpad, sorry for that). But now I take a closer look, int m_resX, m_resY; QStringList m_scaleByResX, m_scaleByResY, m_toRadians; are only used in getPropertyScale(). So can you keep "int m_resX, m_resY; QStringList m_scaleByResX, m_scaleByResY, m_toRadians;" in SynapticsTouchpad, and make getPropertyScale a virtual function. Make a new default implemetation of getPropertyScale in XlibTouchpad that simply returns 1.0. - Xuetian Weng On March 8, 2016, 9:11 p.m., Rajeesh K V wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127306/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 9:11 p.m.) > > > Review request for Plasma, David Edmundson and Xuetian Weng. > > > Bugs: 359460 > https://bugs.kde.org/show_bug.cgi?id=359460 > > > Repository: plasma-desktop > > > Description > ------- > > Fixes few things: > 1. Remove redefined members of parent class XlibTouchpad from > SynapticsTouchpad class fixing wrong scroll delta values. > 2. Enlarge vertical,horizontal&circular scroll delta and maxtapmove allowing > value more than 100. The max value supported by driver is 1000. > > I would like to get this fix in 5.6 final. > > > Diffs > ----- > > kcms/touchpad/src/backends/x11/synapticstouchpad.h de75125 > kcms/touchpad/src/backends/x11/synapticstouchpad.cpp 1e01894 > kcms/touchpad/src/kcm/touchpad.kcfg d4d127c > kcms/touchpad/src/kcm/ui/scroll.ui d1c2f76 > kcms/touchpad/src/kcm/ui/tap.ui 389db5e > > Diff: https://git.reviewboard.kde.org/r/127306/diff/ > > > Testing > ------- > > Built the RPM, compile tested and locally tested. Bug reporters confirm patch > fixes the issue. > > > Thanks, > > Rajeesh K V > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
