----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128362/#review97112 -----------------------------------------------------------
I don't like the hard coding of the dbus service name. But I'm also lacking ideas how we could not hard code it. On X11 we could use the root-window property ORG_KDE_DBUS_SERVICE_NAME, but for Wayland we have no way to figure out the name. src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h (line 156) <https://git.reviewboard.kde.org/r/128362/#comment65594> @since 5.25 src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h (line 163) <https://git.reviewboard.kde.org/r/128362/#comment65595> @since 5.25 - Martin Gräßlin On July 4, 2016, 8:38 p.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128362/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 8:38 p.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This is the remaining useful code from the Tasks engine, which is now > scheduled for removal. It will be used by the Window List plasmoid. > > As discussed on IRC. > > > Diffs > ----- > > src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt ce0ea74 > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h a9db965 > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp 4850011 > > Diff: https://git.reviewboard.kde.org/r/128362/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
