> On July 5, 2016, 4:32 p.m., Martin Gräßlin wrote:
> > I do not understand why this review was discarded. Care to elaborate?
> 
> Eike Hein wrote:
>     Based on IRC discussion neither you or I are are available to write the 
> favored implementation so I decided to abandon the proposed code.

But then the stringly based might be better. I don't see why you discarded the 
review.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128362/#review97125
-----------------------------------------------------------


On July 5, 2016, 4:13 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128362/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 4:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is the remaining useful code from the Tasks engine, which is now 
> scheduled for removal. It will be used by the Window List plasmoid.
> 
> As discussed on IRC.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt ce0ea74 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h a9db965 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp 4850011 
> 
> Diff: https://git.reviewboard.kde.org/r/128362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to