----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/#review97333 -----------------------------------------------------------
Only the original string should be changed, not the translations. Have you run this by Thomas Pfeiffer, these strings are the result of careful restructuring we did before 5.0. Also, we shouldn't change these names too lightly, since they're very user-visible and important to recognized. Many people remember these names, so we're introducing quite come re-learning to users with it. kcms/baloo/kcm_baloofile.desktop (line 22) <https://git.reviewboard.kde.org/r/128434/#comment65700> The <name>[$LANG] lines are all automatically added, they are generated by the translation system. That means that the translators will take care of that. The patch should only change the first line, without the []. The translations will then be automatically updated a few hours later by the "scripty" daemon, once translators have picked up the string changes. - Sebastian Kügler On July 12, 2016, 11:41 p.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128434/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 11:41 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > change see in the diff > > > Diffs > ----- > > kcms/baloo/kcm_baloofile.desktop 919fc8e > kcms/desktoppaths/desktoppath.desktop 2567c76 > kcms/keys/keys.desktop ac6afb6 > kcms/ksmserver/kcmsmserver.desktop 8ed358b > kcms/phonon/kcm_phonon.desktop ed804a3 > kcms/standard_actions/standard_actions.desktop a454dbd > kcms/translations/translations.desktop daf9469 > > Diff: https://git.reviewboard.kde.org/r/128434/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
