----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/#review97343 -----------------------------------------------------------
See the inline comments. The things I've +1'd can be shipped from my perspective kcms/baloo/kcm_baloofile.desktop (line 15) <https://git.reviewboard.kde.org/r/128434/#comment65707> Hm, I'm not sure. From a user's perspective, it's relevant where the search can find things, "indexing" is more of an implementation detail for the user. kcms/keys/keys.desktop (line 14) <https://git.reviewboard.kde.org/r/128434/#comment65708> I thought we wanted to have both in the same KCM, just under different headings? We should only change that if we actually decide to split all application shortcuts out into a separate KCM. kcms/ksmserver/kcmsmserver.desktop (line 3) <https://git.reviewboard.kde.org/r/128434/#comment65709> +1 kcms/phonon/kcm_phonon.desktop (line 13) <https://git.reviewboard.kde.org/r/128434/#comment65710> It does also contain settings for video recording devices, so it is not just audio. kcms/standard_actions/standard_actions.desktop (line 15) <https://git.reviewboard.kde.org/r/128434/#comment65711> +1 kcms/translations/translations.desktop (line 14) <https://git.reviewboard.kde.org/r/128434/#comment65712> +1 - Thomas Pfeiffer On July 13, 2016, 8:26 a.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128434/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 8:26 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > change see in the diff > > > Diffs > ----- > > kcms/baloo/kcm_baloofile.desktop 919fc8e > kcms/desktoppaths/desktoppath.desktop 2567c76 > kcms/keys/keys.desktop ac6afb6 > kcms/ksmserver/kcmsmserver.desktop 8ed358b > kcms/phonon/kcm_phonon.desktop ed804a3 > kcms/standard_actions/standard_actions.desktop a454dbd > kcms/translations/translations.desktop daf9469 > > Diff: https://git.reviewboard.kde.org/r/128434/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > adjustments > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel