sebas added inline comments. INLINE COMMENTS
> compositing.ui:9 > <y>0</y> > - <width>481</width> > - <height>349</height> > + <width>815</width> > + <height>510</height> resize the window before saving, that means it saves the minimum size, rather than a random one > compositing.ui:24 > </property> > - <property name="text"> > + <property name="text" stdset="0"> > <string>OpenGL compositing (the default) has crashed KWin in the > past. dunno where this comes from, and what it means ... also in the following places > compositing.ui:290 > + <string>Applications can set a hint to block compositing when the > window is open. > + This brings performance improvement for e.g. games. > + The setting can be overruled by window specific rules.</string> improvements (plural) > options.h:193 > Q_PROPERTY(KWin::OpenGLPlatformInterface glPlatformInterface READ > glPlatformInterface WRITE setGlPlatformInterface NOTIFY > glPlatformInterfaceChanged) > + Q_PROPERTY(bool windowsBlockingCompositing READ > isWindowsBlockingCompositing WRITE setWindowsBlockingCompositing NOTIFY > windowsBlockingCompositingChanged) > public: without the is* ? (It's not required by QML, unlike Thomas suggests) REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, #vdg Cc: sebas, broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts
