[Differential] [Changed Subscribers] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

Mon, 12 Sep 2016 13:04:34 -0700 

sebas added inline comments.

INLINE COMMENTS

> dbusinterface.h:118
>      Q_PROPERTY(QStringList supportedOpenGLPlatformInterfaces READ 
> supportedOpenGLPlatformInterfaces)
> +    Q_PROPERTY(bool platformRequiresCompositing READ 
> isPlatformRequiringCompositing)
>  public:

same name for property and READ accessor?

> compositing.h:50
>      Q_PROPERTY(bool windowsBlockingCompositing READ 
> isWindowsBlockingCompositing WRITE setWindowsBlockingCompositing NOTIFY 
> windowsBlockingCompositingChanged)
> +    Q_PROPERTY(bool compositingRequired READ isCompositingRequired CONSTANT)
>  public:

again, same name instead of using 3 different variations

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2586

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts

Reply via email to