----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/#review99931 -----------------------------------------------------------
CMakeLists.txt (line 68) <https://git.reviewboard.kde.org/r/129148/#comment67112> I guess it should only be optional as otherwise you cannot compile on Android/Windows/OSX any more src/plasmaquick/dialog.cpp (line 1101) <https://git.reviewboard.kde.org/r/129148/#comment67113> please use SurfaceCreatedEvent src/plasmaquick/dialogshadows.cpp (lines 218 - 221) <https://git.reviewboard.kde.org/r/129148/#comment67114> trailing white spaces src/plasmaquick/dialogshadows.cpp (lines 222 - 223) <https://git.reviewboard.kde.org/r/129148/#comment67115> only whitespaces changed. src/plasmaquick/dialogshadows.cpp (lines 229 - 258) <https://git.reviewboard.kde.org/r/129148/#comment67116> complete section seems to be only whitespace changes src/plasmaquick/dialogshadows.cpp (line 296) <https://git.reviewboard.kde.org/r/129148/#comment67117> only whitespace change src/plasmaquick/dialogshadows.cpp (line 310) <https://git.reviewboard.kde.org/r/129148/#comment67118> empty new line src/plasmaquick/dialogshadows.cpp (line 327) <https://git.reviewboard.kde.org/r/129148/#comment67119> only whitespace change src/plasmaquick/dialogshadows.cpp (line 346) <https://git.reviewboard.kde.org/r/129148/#comment67120> only whitespace change src/plasmaquick/dialogshadows.cpp (line 365) <https://git.reviewboard.kde.org/r/129148/#comment67121> only whitespace change src/plasmaquick/dialogshadows.cpp (line 536) <https://git.reviewboard.kde.org/r/129148/#comment67122> only whitespace change - Martin Gräßlin On Oct. 11, 2016, 2:11 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129148/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 2:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > use plasmashell interface for moving the dialog, use kwayland as well for > shadows. > > this is supposed to replace the waylanddialogfilter hack in plasmashell. > > > Diffs > ----- > > CMakeLists.txt 74b0704 > src/plasmaquick/CMakeLists.txt 2dd6a26 > src/plasmaquick/dialog.cpp 5c8879d > src/plasmaquick/dialogshadows.cpp 982de15 > src/plasmaquick/dialogshadows_p.h f8c6207 > > Diff: https://git.reviewboard.kde.org/r/129148/diff/ > > > Testing > ------- > > ran a plasma session in wayland, both with the p-w hack enabled and siabled, > dialogs move and shadows seem to be fine > > > Thanks, > > Marco Martin > >