----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/#review99937 -----------------------------------------------------------
src/plasmaquick/CMakeLists.txt (lines 7 - 11) <https://git.reviewboard.kde.org/r/129148/#comment67126> why are you adding the definition if you have it in config-plasma.h? src/plasmaquick/dialog.cpp (lines 1137 - 1139) <https://git.reviewboard.kde.org/r/129148/#comment67127> maybe destroy in the SurfaceDestroyed event? - Martin Gräßlin On Oct. 11, 2016, 4:44 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129148/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 4:44 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > use plasmashell interface for moving the dialog, use kwayland as well for > shadows. > > this is supposed to replace the waylanddialogfilter hack in plasmashell. > > > Diffs > ----- > > CMakeLists.txt 74b0704 > src/plasma/config-plasma.h.cmake ed14e7a > src/plasmaquick/CMakeLists.txt 2dd6a26 > src/plasmaquick/dialog.cpp 5c8879d > src/plasmaquick/dialogshadows.cpp 982de15 > src/plasmaquick/dialogshadows_p.h f8c6207 > > Diff: https://git.reviewboard.kde.org/r/129148/diff/ > > > Testing > ------- > > ran a plasma session in wayland, both with the p-w hack enabled and siabled, > dialogs move and shadows seem to be fine > > > Thanks, > > Marco Martin > >