denisshienkov added inline comments.
INLINE COMMENTS
> volkov wrote in powerdevilcore.cpp:102
> Yes, powermanagement.{h, cpp} from kscreenlocker is what you need.
> The question is whether to create a library from it?
> The question is whether to create a library from it?
I don't know. It is not in my competence. I just can do copy/paste a code from
kscreenlocker.
> volkov wrote in activitypage.cpp:76
> Why don't make QWeakPointer -> QPointer commit first and base this one on it?
> Why don't make QWeakPointer -> QPointer
1. Then, I suggest do not use QPointer at all, as it is overhead for this case.
I suggest to use the pointers directly..
> commit first and base this one on it?
I don't know how to do it with phabricator. It is my first issue in here. :)
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4939
To: denisshienkov, volkov, afiestas
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
