denisshienkov added inline comments.

INLINE COMMENTS

> denisshienkov wrote in activitypage.cpp:76
> > Why don't make QWeakPointer -> QPointer
> 
> 
> 
> 1. Then, I suggest do not use QPointer at all, as it is overhead for this 
> case. I suggest to use the pointers directly..
> 
> > commit first and base this one on it?
> 
> I don't know how to do it with phabricator. It is my first issue in here. :)

> I don't know how to do it with phabricator. It is my first issue in here. :)

Please see https://phabricator.kde.org/D4970

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4939

To: denisshienkov, volkov, afiestas
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to