dvogel updated this revision to Diff 13395. dvogel marked 6 inline comments as done. dvogel added a comment.
Applied changes suggested by reviewers. The only issue remaining is brightness restoration when waking up the monitor after shutting it down: we try to set brightness before the monitor is actually ready. Setting then fails, and the monitor wakes up with the last value it was dimmed to before shut down. TODO: Make ddcutillib optional, for now not having ddcutil installed will most likely result in a crash. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=13291&id=13395 REVISION DETAIL https://phabricator.kde.org/D5381 AFFECTED FILES daemon/backends/CMakeLists.txt daemon/backends/upower/ddcutilbrightness.cpp daemon/backends/upower/ddcutilbrightness.h daemon/backends/upower/powerdevilupowerbackend.cpp daemon/backends/upower/powerdevilupowerbackend.h To: dvogel, broulik Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol