dvogel updated this revision to Diff 14843. dvogel added a comment.
Absence of ddcutil on the system is now handled: the ddcbrightness object is still instantiated in powerdevilupowerbackend, however, this is a dummy object, returning isSupported()=FALSE, making powerdevilupowerbackend avoid using ddcutil. The same brightness is applied to all ddc-capable displays this seems to be the most obvious choice (compared to setting only one monitor) Multi-monitor not tested: - desktop + 2+ monitors: should work, as ddcutilbrightness supports multiple monitors - laptop + external monitor: not tested, when plugging a new monitor while the laptop LCD is already used for brightness ==> detection is just triggered when powerdevil starts, so should be fine; when booting with external monitor attached ==> ddcutil is the last possibility in ddcutilupowerbackend.cpp, the laptop LCD should always be controlled. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=13586&id=14843 REVISION DETAIL https://phabricator.kde.org/D5381 AFFECTED FILES CMakeLists.txt cmake/FindDDCUtil.cmake daemon/backends/CMakeLists.txt daemon/backends/upower/ddcutilbrightness.cpp daemon/backends/upower/ddcutilbrightness.h daemon/backends/upower/powerdevilupowerbackend.cpp daemon/backends/upower/powerdevilupowerbackend.h To: dvogel, broulik Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
