graesslin added inline comments. INLINE COMMENTS
> filtered_display.cpp:41 > + auto t = static_cast<FilteredDisplay::Private*>(data); > + auto clientConnection = > t->q->getConnection(const_cast<wl_client*>(client)); > + auto interface = wl_global_get_interface(global); Why a const cast? Or other said: could we overload the getConnection to accept a const wl_client*? > filtered_display.cpp:45 > + return t->q->allowInterface(clientConnection, name); > + return false; > + }; that looks like dead code. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
