graesslin added inline comments. INLINE COMMENTS
> davidedmundson wrote in filtered_display.cpp:41 > I tried. > > modding getConnection means modding modding ClientConnection constructor, > modding that means modding the Private ctor > > that gets into > > wl_client_add_destroy_listener(c, &listener); > > c is now const, that fails. > > ---- > > We have 3 options: > > - a const_cast somewhere > - Change Display to create ClientConnections when they come in, not on > demand, then we can make getconnection const everywhere. (IMHO, maybe worth > it, as our current clientConnected signal is rather misleading) > - return PID in the API here instead of the client. ouch, then const_cast is clearly better. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
