amantia added inline comments. INLINE COMMENTS
> mwolff wrote in screenmapper.cpp:85 > this should imo be a for loop to make it clear that it is iterating over all > items (more ideomatic). Also, couldn't you use range-based for here even? range based loop: I need access to both key and value > mwolff wrote in screenmapper.cpp:91 > this is actually shared with above, so that could be in a lambda I don't see what can be extracted REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
