amantia added inline comments. INLINE COMMENTS
> hein wrote in foldermodel.cpp:1688 > I know it's a very theoretical case, but you're not disconnecting from an old > non-null ScreenMapper here. > > You're also not calling invalidateFilter even though filterAcceptsRow uses > the mapper. It's all a bit non-hygienic in the sense of "allow stuff to be > set and reset in any order". Which can be somewhat important, especially as > FolderModel doesn't inherit from QQmlParserStatus (hint: would be a great > follow-up patch) and sometimes things can fall apart in config-dependent ways > during initialization. > > I'd appreciate a pass through this code for that concern for good Qt Quick > hygiene. As it ScreenMapper is a singleton, this will never happen, but nevertheless I added the disconnect. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
