broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land.
Please remove the unrelated changes before pushing INLINE COMMENTS > foldermodel.cpp:1896-1900 > + if (m_appletInterface) { > + Plasma::Applet *applet = > m_appletInterface->property("_plasma_applet").value<Plasma::Applet *>(); > + QQuickItem* gObj = qobject_cast<QQuickItem > *>(applet->property("_plasma_graphicObject").value<QObject *>()); > + uiDelegate.setQWindow(gObj->window()); > + } Unrelated? > foldermodel.cpp:1918-1922 > + if (m_appletInterface) { > + Plasma::Applet *applet = > m_appletInterface->property("_plasma_applet").value<Plasma::Applet *>(); > + QQuickItem* gObj = qobject_cast<QQuickItem > *>(applet->property("_plasma_graphicObject").value<QObject *>()); > + uiDelegate.setQWindow(gObj->window()); > + } Unrelated? > foldermodel.cpp:1956-1960 > + if (m_appletInterface) { > + Plasma::Applet *applet = > m_appletInterface->property("_plasma_applet").value<Plasma::Applet *>(); > + QQuickItem* gObj = qobject_cast<QQuickItem > *>(applet->property("_plasma_graphicObject").value<QObject *>()); > + uiDelegate.setQWindow(gObj->window()); > + } Unrelated? REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma, broulik Cc: broulik, ngraham, kossebau, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart