hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land.
In D10438#205230 <https://phabricator.kde.org/D10438#205230>, @zzag wrote: > > I'm not sure whether these changes should come with this diff or maybe I should create another diff which "fixes" alignment of check boxes. @ngraham, @hpereiradacosta, @abetts what do you think? This should go in a different patch. > --- > > Also, is there a bug report about missing shortcut hints when icons in menus are disabled? Not that I know. Also: I cannot reproduce. Here, if I uncheck "Show Icons in Menus" in system settings->widget style->Fine tuning, icons dissapear and shortcut are still there. Or are we talking about a different settings ? In any case, this change is ready to land. Thanks ! REPOSITORY R31 Breeze BRANCH menuitem-margins REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
