fvogt updated this revision to Diff 30248. fvogt added a comment.
libdbusmenu-qt: Remove nonexistant actions directly from the menu The getLayout response handler compares the new list of actions with the current actions in the menu and calls deleteLater on all actions which aren't part of the new list anymore. Then, it adds all actions from the new list which aren't part of the menu yet. As deleteLater only has an effect after the next event processing, the menu still contains them together with the added actions. This resulted in broken size calculations, as even for static menus the item count changed during aboutToShow. Note that this is not a proper solution for the resize issue, as the aboutToShow handler changes the menus content for a reason, the application is free to add/remove items at any point in time. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11584?vs=30245&id=30248 BRANCH snitest REVISION DETAIL https://phabricator.kde.org/D11584 AFFECTED FILES applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml applets/systemtray/systemtray.cpp libdbusmenuqt/dbusmenuimporter.cpp To: fvogt, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
