fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in StatusNotifierItem.qml:63
> I think this change is fine. Except that the `MouseArea` covers the entire 
> list item, so for hidden SNIs the app might get coordinates outside of its 
> icon.
> 
> For context menu we ignore the coordinates anyway and place the menu relative 
> to the icon (so it never covers it). For `Activate` the app might want to 
> know where it was clicked. In any case this needs a bit of cleaning up, we 
> pass parameters around in places where they're ignored and so on.

I think I'll do it differently.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to