ngraham added a comment.
Okay I've deployed the patch, and without applying the change specified in the "For testing..." sentence, I was unable to find any visual changes from the status quo resulting from this patch. Is that intentional? For example `QT_SCREEN_SCALE_FACTORS=3 kate` does not show me the "After" picture when I open a file open dialog. Might be worth updating the Test Plan section to describe exactly what's necessary to test this patch. Question: what is the technical difference between `QT_SCALE_FACTOR=2` and `QT_SCREEN_SCALE_FACTORS=2`? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol